[feature/guest-links] bump reva, add service user config to "sharing" service#2735
[feature/guest-links] bump reva, add service user config to "sharing" service#2735rhafer wants to merge 2 commits into
Conversation
…ervice In order to be able to run migrations, the "sharing" service now needs the "service_account_id" and -"_secret" to be configured. This is a "breaking/backwards incompatible" change.
ed65dea to
ef24b9f
Compare
|
There was a problem hiding this comment.
Pull Request Overview
The Pull Request as submitted contains no code changes, which precludes any verification of the stated goals: bumping the reva dependency and adding service user configuration to the sharing service. While automated analysis marks the PR as 'up to standards', this is a false positive resulting from the absence of modified files to analyze.
Significant gaps exist for all acceptance criteria. There is no evidence of the dependency update or the logic required to enforce service account configurations during migrations. This PR should not be merged in its current state.
About this PR
- The Pull Request does not contain any code changes. The intended 'reva' dependency bump and configuration updates for the 'sharing' service are missing from the fileset.
- Jira ticket information is missing, which is necessary to verify the implementation against the broader guest-links feature requirements.
Test suggestions
- Verify reva dependency version update in the dependency manifest (e.g., go.mod).
- Verify configuration validation logic for the service account in the sharing service.
- Verify that migrations fail or exhibit correct error behavior when service account configuration is missing.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify reva dependency version update in the dependency manifest (e.g., go.mod).
2. Verify configuration validation logic for the service account in the sharing service.
3. Verify that migrations fail or exhibit correct error behavior when service account configuration is missing.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Up to standards ✅🟢 Issues
|



This bumps reva to the latest code from the
feature/guest-linksbranch. Also adjust the "sharing" service to require the service account to be configured to be able to run migrations.